Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate is_demo_user #1571

Closed
jsangmeister opened this issue Jan 6, 2023 · 2 comments
Closed

Reactivate is_demo_user #1571

jsangmeister opened this issue Jan 6, 2023 · 2 comments

Comments

@jsangmeister
Copy link
Contributor

jsangmeister commented Jan 6, 2023

The field is_demo_user is currently not evaluated in the backend. In OS3, the following routes were forbidden to be used on users where the flag was set:

  • update
  • set_password
  • reset_password
  • bulk_set_state
  • bulk_alter_groups

Routes which were generally forbidden in demo mode (at least one demo user given), independent of the payload:

  • bulk_generate_passwords
  • bulk_reset_passwords_to_default
  • destroy
  • bulk_delete
  • mass_invite_email

Translated to OS4 actions, this would mean the following actions are forbidden:

  • user.update (except group G to update the field is_demo_user)
  • user.update_self
  • user.set_password
  • user.set_password_self
  • user.reset_password_to_default
  • user.generate_new_password
  • user.delete
  • user.send_invitation_email

Additionally, maybe forget_password should also be forbidden.

Another approach for the update actions would be to allow the action itself, but to blacklist specific fields like username.

@r-peschke
Copy link
Member

IMO we decided, that we don't need a demo_user anymore in OS4.
If a kind of demo user is ńecessary, we should solve this with permissions, i.e. create a demo-group with the permissions for a demo user.

@jsangmeister jsangmeister modified the milestones: 4.1, 4.2 Dec 12, 2023
@jsangmeister
Copy link
Contributor Author

currently not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants