-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Add to an existing application section in the Get Started page is out-dated #3329
Comments
I think it is better for this doc to just point to the plugins and the guides and not suggest that they add the dependency for the Liberty runtime to their build file, as that is not how it is usually done. If it is for the end user to know the coordinates, then document it that way. These are the coordinates that can be used in the Liberty Maven/Gradle plugin configuration to use the Liberty runtime. |
Here are good starting points for both Maven and Gradle plugins. Maven: Gradle: |
Note: Long thread in slack with more information |
Liberty Maven plugin configuration - no need to configure the Liberty runtime as it gets the latest
The |
Liberty Gradle plugin configuration - no need to configure the Liberty runtime as it gets the latest
The plugin also needs to be applied in the build file in order to be utilized.
The |
The blog post release templates have been updated to reflect the above. |
we could break then out into 2 separate calls to action for each tool
|
We might want to add some kind of intro statement for the plugin just under the Add to an existing application header. As it it now, we have this sentence between the two examples:
but we haven't said anything about a plugin or introduced it in any way. Something like
and i think this sentence could be improved The plugin also needs to be applied in the build file in order to be utilized. |
Opened Issue #3449 to improve the wording as the code snippets have now been updated. Closing this issue as complete. |
What is the purpose of the Add to an existing application section?
Nowadays, use LMP to get the OL for development.
If this section want users to know how to specify the OL version for LMP, the Maven and Gradle dependency are out-dated.
If this section is for other purpose, suggest to make it clear.
Also this section points users to Maven and Gradle guides. Both guides do not have
dependency
for OL.The text was updated successfully, but these errors were encountered: