Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw warning for user configurations that reference deprecated fields #609

Open
leochr opened this issue Aug 26, 2024 · 0 comments
Open

Comments

@leochr
Copy link
Member

leochr commented Aug 26, 2024

Liberty Operator CRDs embed various APIs (k8s, go, third-party) and as we update the dependency versions, some fields are deprecated to be removed later. It'll be good to output warning for the use of such deprecated APIs in the user configurations (CRs), so that users remove the references to the deprecated API and switch to the new API. This will prevent their configuration from becoming invalid when the deprecated API is later removed and potentially disrupt their applications.

One such example is the deprecation of BearerTokenSecret and BearerTokenFile in Prometheus (monitoring) APIs. But there are likely others (search for 'deprecate' in CRDs).
https://github.com/application-stacks/runtime-component-operator/blob/f0681bdaf060ce2979bbd4ec2c16f1425d70277e/utils/utils.go#L1211

We should throw a warning for use of deprecated fields of our Operators as well (i.e. .spec.serviceAccountName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@leochr and others