Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded paths #81

Open
JostMigenda opened this issue Jun 7, 2024 · 0 comments
Open

Replace hardcoded paths #81

JostMigenda opened this issue Jun 7, 2024 · 0 comments

Comments

@JostMigenda
Copy link
Collaborator

JostMigenda commented Jun 7, 2024

[From discussion on a separate PR]

The plugin CemrgApp/Plugins/kcl.cemrgapp.easi/ contains a few hard-coded paths to local directories. We should either update this with a user-supplied path, or remove the plugin, since it appears to be unused at the moment.

Same in CemrgTests.cpp—which has almost 50 hits when searching for /home/or15 (though many are commented out).

Those two files seem to be the only ones in the CemrgApp codebase that are affected.

@JostMigenda JostMigenda changed the title Replace hardcoded paths in Replace hardcoded paths in CemrgApp/Plugins/kcl.cemrgapp.easi/ Jun 7, 2024
@JostMigenda JostMigenda mentioned this issue Jun 7, 2024
@JostMigenda JostMigenda changed the title Replace hardcoded paths in CemrgApp/Plugins/kcl.cemrgapp.easi/ Replace hardcoded paths Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant