Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove check for readings unavailable #1395

Open
huss opened this issue Nov 27, 2024 · 1 comment
Open

remove check for readings unavailable #1395

huss opened this issue Nov 27, 2024 · 1 comment
Assignees
@danielshid
Labels
p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Milestone
2.0 release

Comments

@huss
Copy link
Member

huss commented Nov 27, 2024

Is your feature request related to a problem? Please describe.

Before the Redux Toolkit, src/client/app/components/RadarChartComponent.tsx checked for readings === undefined because the reading might still being fetched. This probably no longer needs to be done. See the TODO in that file.

Describe the solution you'd like

Remove and test that okay.

Describe alternatives you've considered

Don't remove code.

Additional context

None
@huss huss added t-enhancement This issues tracks a potential improvement to the software p-medium-priority labels Nov 27, 2024
@huss huss added this to the 2.0 release milestone Nov 27, 2024
@danielshid
Copy link
Contributor

I will be working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielshid danielshid

Labels
p-medium-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Milestone
2.0 release
Development

No branches or pull requests
2 participants
@huss @danielshid