Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies between actions not enforced #22

Open
baszoetekouw opened this issue Oct 21, 2024 · 1 comment
Open

dependencies between actions not enforced #22

baszoetekouw opened this issue Oct 21, 2024 · 1 comment

Comments

@baszoetekouw
Copy link
Member

baszoetekouw commented Oct 21, 2024

There are a number of dependencies between the base containers (for example, "PHP 7.2 Apache2 Node14 Composer2" depends on the "PHP 7.2 Apache2" container), but those are not expressed in the github action flows. This can cause race issues because the dependent container starts building before the dependency is available. See for example https://github.com/OpenConext/OpenConext-BaseContainers/actions/runs/11322704037/attempts/1.

I'm not sure how to solve this, except for creating a single workflow with multiple stages.

@quartje
Copy link
Contributor

quartje commented Oct 22, 2024

The older version should still be available. We build so often that it shouldn't matter. The not found is odd, since there is a container. Older images are deleted after some time but should still be there. It feels more like a caching issue.
We might just adjust the cron schedule and run them one after the other with one or two hour time slots in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants