Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] PoC Frontend Error Log Collector Implementation #1959

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

savacano28
Copy link
Contributor

Proposed changes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 changed the title Issue/collector frontend errors [backend/frontend] PoC Frontend Error Log Collector Implementation Nov 29, 2024
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 33.61%. Comparing base (04f69f8) to head (97890e9).

Files with missing lines Patch % Lines
...llector_frontend_error/form/ErrorDetailsInput.java 0.00% 4 Missing ⚠️
.../openbas/rest/collector_frontend_error/LogApi.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1959      +/-   ##
============================================
- Coverage     33.62%   33.61%   -0.01%     
- Complexity     1671     1673       +2     
============================================
  Files           572      574       +2     
  Lines         16697    16705       +8     
  Branches        970      970              
============================================
+ Hits           5614     5616       +2     
- Misses        10829    10835       +6     
  Partials        254      254              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 force-pushed the issue/collector-frontend-errors branch from a8d8aef to 97890e9 Compare November 29, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants