-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable blue light schedule to work for Miyoo Minis with RTC #1706
base: main
Are you sure you want to change the base?
Conversation
stianKristensen
commented
Nov 24, 2024
•
edited
Loading
edited
- Enables the blue light schedule to work for the new Miyoo Mini V4 with RTC (or earlier revisions that have been modded).
- Prevent the blue light filter from always starting enabled on boot when the schedule says it should be off.
- Removed the network requirement, instead opting to blindly follow the current clock time if schedule is enabled.
…y_on as it is handled by functions, remove blf_key_on_user if blue light not on during check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like if we checked for the noTimeRestore flag, instead of showing the options for all.
Good idea! I'll change the checks for the miyoo mini + that I removed to instead check the noTimeRestore. |
Correction: I'll add to the checks so that they will be visible if it is a mini plus OR the noTimeRestore exists (so non-rtc mini plus with network time still works) |
I've added what you suggested, along with making sure the schedule options are always available if the .blf flag exists. This allows Miyoo Mini Plus owners without RTC to still turn off the schedule if they've turned off the network sync. |
… settings.noTimeRestore to use snakecase instead)