Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Identity Verification is fully broken for all users #1095

Open
bmulholland opened this issue Aug 18, 2023 · 9 comments
Open

[Bug]: Identity Verification is fully broken for all users #1095

bmulholland opened this issue Aug 18, 2023 · 9 comments

Comments

@bmulholland
Copy link

bmulholland commented Aug 18, 2023

What happened?

getJWTHeader literally isn't called anywhere. Just search the repo. That's the only place that sets the Authorization header required by Identity Verification.

so Identity Verification is not supported by this library. At all!

Shouldn't tests cover that or something? Why am I debugging mission-critical parts of this SDK?

What browsers are you seeing the problem on?

Firefox, Chrome (Chromium)

What operating system are you running?

Steps to reproduce?

turn on identity verification

note that identity calls fail now

look at code and see that there is no code path that calls getJWTHeader

What did you expect to happen?

Relevant log output

No response

@bmulholland bmulholland changed the title [Bug]: logging in doesn't pass through token [Bug]: Identity Verification is fully broken for all users Aug 18, 2023
@jkasten2
Copy link
Member

jkasten2 commented Aug 18, 2023

@bmulholland Thanks for reporting.

Identity Verification id not available yet with our just released User Model APIs. Sorry we did not make this clear in our release notes and documentation, we are correcting that.

Adding Identity Verification support is one of the top things we are working since introducing User Model. However you may use our older SDK and APIs until we have support.
See our v9.0 documentation for the Player Model APIs:
https://documentation.onesignal.com/v9.0/docs/identity-verification

@bmulholland
Copy link
Author

Okay but then the code should also detect this scenario and throw an appropriate error. There’s standard things to be done to make these things reasonable for the users of the software.

I spent my entire day today essentially QAing and beta testing this release without even being clear I was opting in to that. The code is broken and the docs are a mix of old and new, broken all over. Support never even responded. Incredibly frustrating.

@KDederichs
Copy link

Honestly...
Why the heck are you guys even releasing a new Major version when you KNOW it's broken?
What's the point here?
Why not release it as alpha/beta?

I tried updating cause I kind of need the foregroundWillDisplay event but it's blowing up left and right. (Been spamming all my errors into the https://github.com/OneSignal/react-onesignal repo)

The current state of this is practically not usable at all.

@sherwinski
Copy link
Contributor

Closing this due to lack of activity. If this remains an issue, please open a new report with updated information and we will investigate. Thanks

@bmulholland
Copy link
Author

bmulholland commented Nov 2, 2024

@sherwinski Well, what's the status of identity verification? A little while ago, I noticed the docs added it, so I'd taken a shot at enabling it, but couldn't get it to work. I wrote support, who told me that -- despite the docs having instructions to set it up for a full month, at that point -- it wasn't actually launched yet.

So -- is it launched? Is it actually tested and functionally working? I've had a very, very poor experience every time I try to upgrade to the latest API. It's wasted a ton of my time. How do I know that won't happen again?

@sherwinski
Copy link
Contributor

Thanks for your response @bmulholland. I followed up with the team and see now that we are still expecting to release identity verification for the web in the future. Apologies for the confusion on my part!

Seeing as how that's the case, I'm going to reopen this issue so that we can track this feature and communicate any information related to its release.

@sherwinski sherwinski reopened this Nov 4, 2024
@bmulholland
Copy link
Author

bmulholland commented Nov 5, 2024

I mean that's pretty wild, considering the docs have been up for two months, the feature still isn't out, and the docs contain no note that this feature isn't even supported yet... https://documentation.onesignal.com/docs/identity-verification

I contacted support about it on Sept 19, after they'd been out for three weeks, only to be told it wasn't out yet... And nothing since.

@sherwinski
Copy link
Contributor

For what it's worth, there is a note in the docs stating that it is only available for iOS at the moment. But I agree that it could be made more apparent to users.

@bmulholland
Copy link
Author

As you mention, that's buried. But even within the banner, it's buried: "not available for Web" is literally the last word. If I was reading these docs, I'd read the title, see it mentions only iOS, and move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants