Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically handle old package PRs #2

Open
Octogonapus opened this issue Mar 27, 2023 · 0 comments
Open

Automatically handle old package PRs #2

Octogonapus opened this issue Mar 27, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Octogonapus
Copy link
Owner

Assuming that:

  1. JuliaRegistrator is secure and can't be tricked into posting a comment that an author created a PR who didn't actually create it

We could automatically ignore PRs if:

  1. The PR introduces a package that already exists
  2. We can find the PR that introduced the package already in the registry
  3. Both PRs are from the same author
  4. The PR being scanned is older than the one that was merged

This happens a lot because package authors sometimes:

  1. Open PR 1
  2. PR 1 is rejected for naming/etc.
  3. Open PR 2
  4. PR 2 is merged
  5. PR 1 is never closed
@Octogonapus Octogonapus added the enhancement New feature or request label Mar 27, 2023
@Octogonapus Octogonapus self-assigned this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant