Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to drop Java 8 support? #65

Closed
desruisseaux opened this issue Feb 4, 2023 · 2 comments
Closed

When to drop Java 8 support? #65

desruisseaux opened this issue Feb 4, 2023 · 2 comments
Labels
question Further information is requested
Milestone

Comments

@desruisseaux
Copy link
Collaborator

desruisseaux commented Feb 4, 2023

With the upgrade to GeoAPI 3.0.2 (issue #64), PROJ-JNI is now a Jigsaw module (issue #15). We have done that while preserving Java 8 compatibility by using the multi-version capability of JAR files. However it makes the project more complicated. A few source files are duplicated in the java9 directory with slightly different code, for example with slightly different use of ServiceLoader. Those duplications increase the risk of discrepancies if a developer changes a Java 8 source file and forget to update the corresponding Java 9+ source file. The root pom.xml file is also more complicated with an Ant task for generating the multi-version JAR file.

When can simplify the project by dropping Java 8 support. The question is when? (no need to be now since we have a solution that works for now).

@desruisseaux desruisseaux added the question Further information is requested label Feb 4, 2023
@desruisseaux desruisseaux modified the milestones: 2.0, 2.1 Feb 18, 2023
@desruisseaux
Copy link
Collaborator Author

As discussed in #67, the 2.0 release has a note saying that it may be the last release supporting Java 8. Having hear no comment in the last 2 months, we will proceed unless there is a last minute objection posted on this issue.

desruisseaux added a commit that referenced this issue Apr 26, 2023
@desruisseaux
Copy link
Collaborator Author

Done, except for the use of logger-neutral API which is the subject of issue #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant