drivers: sam: update PLL ready time, add driver for pit64b #7103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The start-up time (simulation data) of sama7g5 PLL is 50us in condition reaching 95% of target frequency. The PLL lock status bit is not set a few times with current timeout setting. Extend the time to make sure the check is successful for any cases. Signed-off-by: Tony Han <[email protected]>
etienne-lms
reviewed
Nov 5, 2024
core/drivers/microchip_pit.c
Outdated
| #include <drivers/clk_dt.h> | ||
| #include <string.h> | ||
|
|
||
| #define MCHP_PIT64B_FREQ 5000000UL /* 5 MHz */ |
| break; | ||
| } | ||
|
|
||
| if (!parent) |
There was a problem hiding this comment.
If no clock was found at line 38, parent is the last tested parent clock, not NULL.
|
|
||
| res = clk_dt_get_by_name(fdt, node, "gclk", &gclk); | ||
| if (res) | ||
| return res; |
There was a problem hiding this comment.
For consistency, I suggest to get the clock first, then to act on clocks:
res = clk_dt_get_by_name(fdt, node, "pclk", &pclk);
if (res)
return res;
- res = clk_enable(pclk);
- if (res)
- panic();
-
res = clk_dt_get_by_name(fdt, node, "gclk", &gclk);
if (res)
return res;
+ res = clk_enable(pclk);
+ if (res)
+ panic();
+| #include <assert.h> | ||
| #include <drivers/clk.h> | ||
| #include <drivers/clk_dt.h> | ||
| #include <string.h> |
There was a problem hiding this comment.
Include also dt_driver.h
Add support for the peripheral PIT64B in sama7g54. In the driver the clocks are initialized for PIT64B. Signed-off-by: Tony Han <[email protected]>
TonyHan11
force-pushed
the
pll_timeout_pit64b
branch
from
39f47aa
to
2ce7559
Compare
|
@etienne-lms updated according to the comments, thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.