Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice refersToProcedure to be removed #715

Open
muricna opened this issue Nov 18, 2024 · 2 comments
Open

Notice refersToProcedure to be removed #715

muricna opened this issue Nov 18, 2024 · 2 comments
Assignees
Labels
aux: mapping it is related to the TED-SWS mappings project module: ePO core ePO core
Milestone

Comments

@muricna
Copy link
Collaborator

muricna commented Nov 18, 2024

The Notice refersToProcedure is a duplicate of ResultNotice refersToProcedure and creates confusion as it could be used for CompetitionNotice which announcesProcedure. Specific predicates should be used for each type of Notice to ease querying.

@cristianvasquez
Copy link
Contributor

This point is open to debate, as it depends on the types of queries being executed.

For instance, in a query like "Retrieve all notices associated with a specific procedure", using different predicates for each notice type complicates the query. It would require handling multiple predicates through unions or relying on inference.

From a simplicity standpoint, I believe a single predicate should be used. The relationship with the procedure can already be inferred from the notice type. For example, a ResultNotice conveys the results of a procedure. Notices are already distinguishable by their class (ResultNotice, CompetitionNotice) and the value of epo:hasNoticeType.

I suggest moving this discussion and analysing a couple of queries, to understand the tradeoffs

@muricna
Copy link
Collaborator Author

muricna commented Nov 20, 2024

Notice refersToProcedure is wrong because it has a cardinality of 1. A planning notice does not refer to a Procedure. Even if the cardinality is relaxed I do not think it should have the same relation as the result notice. It could be something like isAbout but this would not enable the querying of all notices since as previously stated the planning notices would be excluded.

@andreea-pasare andreea-pasare self-assigned this Nov 25, 2024
@andreea-pasare andreea-pasare added aux: mapping it is related to the TED-SWS mappings project module: ePO core ePO core labels Nov 25, 2024
@andreea-pasare andreea-pasare added this to the 5.0.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aux: mapping it is related to the TED-SWS mappings project module: ePO core ePO core
Projects
None yet
Development

No branches or pull requests

3 participants