Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade of Application does not happen, when /usr/share is in a volume #59

Open
sstidl opened this issue Jun 17, 2021 · 5 comments
Open

Comments

@sstidl
Copy link

sstidl commented Jun 17, 2021

hi

thanks for your useful software!

I tried to find out why table software_categories_link was missing and found out, that the docker-entrypoint does only copy the new code if var.php does not exist and therfore the /files/update/ directory doesnt get updated.

if [ ! -f $OCS_WEBCONSOLE_DIR/ocsreports/var.php ]; then

as we mount $OCS_WEBCONSOLE_DIR it has var.php already

- "ocsreportsdata:/usr/share/ocsinventory-reports/ocsreports"

I tried to remove the mount and now ocs db schema gets upgraded

could you find out if this works correctly?

@gillesdubois
Copy link
Member

Hi @sstidl

Thanks for your contribution.

I'm looking at the #57 alongside with your issue :)

I don't think its mandatory to keep ocsreports as a volume, I just have to set the extensions directory as a volume.

Regards,
Gilles.

@gillesdubois
Copy link
Member

Hi @sstidl

Could you try to build an image locally using the changes in this PR : #60

Regards,
Gilles.

@sstidl
Copy link
Author

sstidl commented Jul 7, 2021

Sorry, I didn't test it yet. I will try to test it by the weekend

@sstidl
Copy link
Author

sstidl commented Jul 9, 2021

I looked at the change in #60 and this should do it.

But it's a breaking change, as you use the same path on host side to mount now into extensions directory. So upgrades will have data in the extensions directory coming from the old mount.

Wouldn't it be better if you choose another and new directory on host side in docker-compose?

@Neustradamus
Copy link

@gillesdubois: Can you look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants