Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [ADD] gitlab #176

Closed
wants to merge 1 commit into from
Closed

Conversation

ByteMeAsap
Copy link

This module does not provide a functionality by itself but a base model
to implement gitlab related features

Library name and description changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong repo?

@flotho
Copy link
Member

flotho commented Sep 18, 2024

think the same thing @chienandalu

@ByteMeAsap
Copy link
Author

Wrong repo?

@chienandalu , can you suggest appropriate repo for adding this module? I would be using this module as a dependent module for creating a module for logging gitlab commits,PRs as membership activities(refer #174)

@chienandalu
Copy link
Member

I guess server-backend would be more appropiate. What do you think @pedrobaeza

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 19, 2024
@pedrobaeza
Copy link
Member

I new repository may be created, like we have interface-github. Anyway, I think this module is very weak and should incorporate more things to be useful for anyone, apart from #174, which is not very related with Gitlab itself.

@ByteMeAsap
Copy link
Author

I new repository may be created, like we have interface-github. Anyway, I think this module is very weak and should incorporate more things to be useful for anyone, apart from #174, which is not very related with Gitlab itself.

@pedrobaeza So, should this module be kept as a part of this repo? or should we incorporate the features of this module in the other module for membership_activity?

@pedrobaeza
Copy link
Member

I don't still understand the goal of the gitlab module, and as said, it's very weak for a complete module, as it's not tied at all to Gitlab in any sense.

@tarteo
Copy link
Member

tarteo commented Oct 4, 2024

@pedrobaeza This module is a technical module it's not meant for the user to do anything. It's meant for other modules to use that need a gitlab connection. #174 is not related to gitlab, but we have created another module that logs / creates membership activity based on commits, pull requests (merge requests), opening issues etc etc. which we will also propose.

But yes this module is not supposed to be here I would suggest server-backend.

@ByteMeAsap
Copy link
Author

Created a PR in server-backend - OCA/server-backend#311

@ByteMeAsap ByteMeAsap closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants