-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [ADD] gitlab #176
[16.0] [ADD] gitlab #176
Conversation
Library name and description changes
00bf03e
to
64b72ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong repo?
think the same thing @chienandalu |
@chienandalu , can you suggest appropriate repo for adding this module? I would be using this module as a dependent module for creating a module for logging gitlab commits,PRs as membership activities(refer #174) |
I guess server-backend would be more appropiate. What do you think @pedrobaeza |
I new repository may be created, like we have interface-github. Anyway, I think this module is very weak and should incorporate more things to be useful for anyone, apart from #174, which is not very related with Gitlab itself. |
@pedrobaeza So, should this module be kept as a part of this repo? or should we incorporate the features of this module in the other module for membership_activity? |
I don't still understand the goal of the |
@pedrobaeza This module is a technical module it's not meant for the user to do anything. It's meant for other modules to use that need a gitlab connection. #174 is not related to gitlab, but we have created another module that logs / creates membership activity based on commits, pull requests (merge requests), opening issues etc etc. which we will also propose. But yes this module is not supposed to be here I would suggest server-backend. |
Created a PR in server-backend - OCA/server-backend#311 |
This module does not provide a functionality by itself but a base model
to implement gitlab related features