-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] membership_initial_fee #167
[16.0][MIG] membership_initial_fee #167
Conversation
Initial fee for memberships =========================== Charge an initial fee when a partner is invoiced for the first time with a member product. Usage ===== Define a member product, and select 'Fixed amount' or 'Percentage of the price' for invoicing an extra charge in the first invoice that is created with this member product.
================================================= Prorrate the membership fee with variable periods ================================================= Helper module for making the prorrate correctly when you are dealing with variable periods in your memberships, which functionality is provided by the module *membership_variable_period*. Installation ============ This module is auto-installed if you have *membership_variable_period* and *membership_prorrate* modules installed. Usage ===== For leading with variable periods and prorrate, only weekly, monthly or yearly periods are allowed. When you create an invoice with a membership product with variable period, the theoretical period is calculated from the invoice date (or today if empty) as the natural period of the selected unit that includes that date. For example, if the invoice is on the 15th of January and the unit is month, the theoretical period to invoice will be all the month of January. Known issues / Roadmap ====================== * Allow to handle periods of months that make the year divisible: 2 months (two-monthly), 3 months (quartely), 4 months (four-monthly) or 6 months (biannual). * On weekly memberships, consider the duality sunday/monday start of the week.
* [IMP] See if partner has any membership line instead of and invoice * Add future possible improvements in README * Fix return at initial_fee_create_check method
Currently translated at 100,0% (10 of 10 strings) Translation: vertical-association-11.0/vertical-association-11.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-11-0/vertical-association-11-0-membership_initial_fee/pt_BR/
Module: membership_initial_fee Summary: - initial_fee_check_create has to be called with the newly created invoice line, not with self. Self is just the model in the create method from which initial_fee_check_create is called. - Keep method compatibility (product argument) - Import order - Add TODO for v12 migration
Currently translated at 100.0% (10 of 10 strings) Translation: vertical-association-11.0/vertical-association-11.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-11-0/vertical-association-11-0-membership_initial_fee/de/
OCA#54) Without changing inter-dependencies, using dynamic code detection.
Currently translated at 100.0% (10 of 10 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_initial_fee/fr/
Currently translated at 100.0% (10 of 10 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_initial_fee/it/
Currently translated at 100.0% (10 of 10 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_initial_fee/it/
Currently translated at 100.0% (10 of 10 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_initial_fee/it/
Currently translated at 70.0% (7 of 10 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_initial_fee/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-14.0/vertical-association-14.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_initial_fee/
Currently translated at 100.0% (13 of 13 strings) Translation: vertical-association-14.0/vertical-association-14.0-membership_initial_fee Translate-URL: https://translation.odoo-community.org/projects/vertical-association-14-0/vertical-association-14-0-membership_initial_fee/it/
8762e5d
to
655fd35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review
@rafaelbn functional and code reviews are ok. Could you merge this please? Thank you! |
/ocabot migration membership_initial_fee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot migration patch
/ocabot merge patch |
On my way to merge this fine PR! |
It looks like something changed on |
Congratulations, your PR was merged at e19c337. Thanks a lot for contributing to OCA. ❤️ |
Standard migration.
@moduon MT-1828
@yajo @EmilioPascual @Shide @rafaelbn review this PR when you can. Thank you!