[ADD] membership_pricelist_assignment #166
Conversation
…t_assignment-15042024 [FIX] website in manifest
…t_assignment-17042024 [FIX] manifest and flake8
…t_assignment-test [ADD] new condition to respect odoo line_state
…t_assignment-test [ADD] new condition to respect odoo line_state
…t_assignment-test [ADD] new condition to respect odoo line_state
…t_assignment-test [ADD] change compute_state
…t_assignment-test [ADD] change compute_state
…t_assignment-test [ADD] change compute_state
|
I'm currently having trouble passing a unit test. It sends the "old" state to a subscription and checks whether the subscription has been set to "old". This is the case, but the test obviously considers that it doesn't. |
…st_assignment-test [FIX] change old state
…st_assignment-test [FIX] change on partner compute
There was a problem hiding this comment.
Thanks for contributing.
I'm a bit confused, this code does things that I wouldn't expected according the module description and seems complicated for its announced goal.
Can you split different concerns in different modules ?
If I understand properly, you try to define a price-list on partners and apply it at some point (at last while generating the invoice) ?
If so could you remove all the code which is not useful on that.
It's quite a long time I've played with the membership module, but I've some doubt according choices that have been made when and how to apply the price list, can we speak about it on Monday?
| @author Romain Duciel <[email protected]> | ||
| License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
| --> | ||
| <odoo> |
There was a problem hiding this comment.
it seems to be a common practice to keep ir.cron records as noupdate to let administrator control crons
| <odoo> | |
| <odoo noupdate="1"> |
| <field | ||
| name="nextcall" | ||
| eval="(DateTime.now() + timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')" | ||
| /> |
There was a problem hiding this comment.
I think this is not necessary
| <field | |
| name="nextcall" | |
| eval="(DateTime.now() + timedelta(days=1)).strftime('%Y-%m-%d 00:00:00')" | |
| /> |
| @@ -0,0 +1,120 @@ | |||
| # Translation of Odoo Server. | |||
There was a problem hiding this comment.
Not sure if OCA bot will do it automatically a membership_pricelist_assignment.pot file should be versioned as well ?
| _inherit = "membership.membership_line" | ||
|
|
||
| pricelist_id = fields.Many2one("product.pricelist", string="Pricelist", store=True) | ||
| user_id = fields.Many2one("res.users", string="Users", store=True) |
There was a problem hiding this comment.
are you realy need this field in this module, I can't see what the purpose ?
| "product.pricelist", | ||
| string="Associated Pricelist", | ||
| help="Pricelist to add to the member", | ||
| store=True, |
There was a problem hiding this comment.
This is useless fields are stored by default unless you add a compute method
| store=True, |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
No description provided.