Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] product_pack: Migration to 16.0 #120

Merged
merged 75 commits into from
Feb 28, 2023

Conversation

FrancoMaxime
Copy link
Member

This pull request is based on the closed pull request (#102).

jjscarafia and others added 30 commits February 23, 2023 14:35
INIT

ADD pot files and module for agrimesores
IMP product pack to support surveyor packs

IMP pack description

IMP add product pack standar functionality for v8 and general improvements

IMP discounts and portal distributors permissions

FIX product_pack license and author

FIX prod pack available

IMP pack to restrict company in products

FIX pack company restriction
IMP product_pack format

FIX fix_digits_compute_to_digits

IMP IMPORTANT imprrovements on product pack, get pack with sale order constraint

IMP use constraint on sale line and not sale order for product packs

IMP implement totalice price on product pack

IMP update pack manifest

FIX prod pack copy sale order

FIX contraint

IMP compt with other modules

FIX prod pack @api.multi
9.0 FIX filter the taxes by company (OCA#111)
* [REL] replace __openerp__ for __manifest__

* [REL] replace openerp imports for odoo

* [REL] some python3 exceptions

* [REL] replace openerp by odoo on xml files

* [REL] delete utf-8 line on python files

* [REL] some minor fixes for migration to v11

* [FIX] runbot link
* [FIX] xml files names

* [REL] migration product_pack to 11.0
* [FIX] Update README
* [FIX] remove openerp tags and data tags
* [IMP] change some funtion to improve funcionality
* [FIX] change name to xml and .py files according guidelines
* [FIX] remove api.one decorators

* [FIX] update readme

* [FIX] Remove "encoding: utf-8"

* [FIX] remove api.multi, string not necesary and some other fixes

* [FIX] demo data to separate according Guidelines

* [FIX] fix names in fields

* [FIX] remove executable
* [ADD] product_pack: Add compatibility with website_sale.

* [ADD] product_pack: Allow product pack modify

* [ADD] product_pack: In sale order do not let to delete/modify a line that
belongs to a pack

* [ADD] product_pack: Be able to edit pack lines inf allow_modify_pack is set in
product.

* [ADD] product_pack: Do not compute price in cart for components_price packs

[FIX] product_pack: Pack line price fixed (take into account pricelist) (OCA#187)

* [FIX] product_pack: Pack line price fixed (take into account pricelist)

Proper compute pack line price using price instead of list_price

* [FIX] product_pack: Allow Modidy Pack only showed for Components price packs

* [FIX] product_pack: When changing pack_price_type clean allow_modify_pack if
needed.
…mplate view (OCA#189)

[FIX] we add prefetch_fields becase if not the stock it's no correct when this method it's call from website (OCA#191)
…scount. (#197)

Formerly was only taking into account the product packs discount, now take
into account both discounts.

Also we simplify the way that get_sale_order_line_vals works and now is
simplier and use Odoo's onchange methods to compute the lines values.

[FIX] product_pack: Pack component now have the tax of the company (#198)

Before this fix the product's packs new sale order line have multiple taxes:
one por each company. Actually only need to add the taxes realated to the
sale order's company.

[FIX] product_pack: compute proper components prices (#199)

In some cases the values were prefetched and it was throwing bad prices.
we add prefetch_fields to the context of the packs and that solve it.

[FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (#201)

* [FIX] product_pack: Do not reset packs components when confirm sale order.

If a sale order is updated from the website whrn confirm the order we do
not expand the pack, we usit as it is.

* [ADD] product_pack: Allow modify pack from backend/website

Now we can choose if the product can be modified in the only int he backend or
if can be modified also in the frontend by the customers.

* [FIX] lint
Currently translated at 95.6% (43 of 45 strings)

Translation: product-pack-12.0/product-pack-12.0-product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-product_pack/pt/
oca-transbot and others added 9 commits February 23, 2023 14:35
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-14.0/product-pack-14.0-product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-14-0/product-pack-14-0-product_pack/
Steps to reproduce the problem:

- Create a new pack with "Pack component price" =
  "Totalized in main product"
- Put some components on it.
- Create a sales order with such pack.
- The price unit got in the sales order line is not the sum of the
  components.

That's because the computations done after calling `price_compute` in
the pricelist engine modify the final returned price, so we don't call
super on such cases and compute it directly.

TT37977
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-15.0/product-pack-15.0-product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-15-0/product-pack-15-0-product_pack/
Copy link

@baimont baimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review, LGTM

@baimont
Copy link

baimont commented Feb 27, 2023

Functional test: the pack products group could be improved

image

@FrancoMaxime
Copy link
Member Author

The view is now fixed

Copy link

@sanrav sanrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional testing OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration product_pack
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 28, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-120-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Feb 28, 2023
5 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#101) has been updated to reference the current pull request.
however, a previous pull request was referenced : #102.
Perhaps you should check that there is no duplicate work.
CC : @JulyChacko1601

@OCA-git-bot OCA-git-bot merged commit 50693c3 into OCA:16.0 Feb 28, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1a0cbc6. Thanks a lot for contributing to OCA. ❤️

@FrancoMaxime FrancoMaxime deleted the 16.0-mig-product-pack branch February 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.