Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use spawn for multiprocessing in nbdev_test #945

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Nov 22, 2024

nbdev uses forkserver for multiprocessing in MacOS, which has been causing some problems in the CI runs. This copies the nbdev_test function and just sets method = 'spawn' regardless of the OS.

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #945 will not alter performance

Comparing nbdev-test-spawn (faf3aa1) with main (1e6d98c)

Summary

✅ 6 untouched benchmarks

@jmoralez jmoralez marked this pull request as ready for review November 22, 2024 18:05
@jmoralez jmoralez merged commit d3dc977 into main Nov 22, 2024
27 checks passed
@jmoralez jmoralez deleted the nbdev-test-spawn branch November 22, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant