Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto arima xreg rank deficient test #931

Merged

Conversation

andrewscottm
Copy link
Contributor

Corrects auto arima "xreg is rank deficient" test, as raised in #902

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024

CLA assistant check
All committers have signed the CLA.

@jmoralez
Copy link
Member

Thanks! Can you please do this instead?

X = np.hstack([np.ones([xregg.shape[0], 1]), xregg])

@andrewscottm
Copy link
Contributor Author

Thanks! Can you please do this instead?

X = np.hstack([np.ones([xregg.shape[0], 1]), xregg])

Done. yes, that's simpler

Copy link
Member

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmoralez jmoralez enabled auto-merge (squash) October 23, 2024 16:58
@jmoralez
Copy link
Member

@andrewscottm can you please sign the CLA? Once that's done this should be automatically merged.

@jmoralez jmoralez added the fix label Oct 23, 2024
@andrewscottm
Copy link
Contributor Author

@andrewscottm can you please sign the CLA? Once that's done this should be automatically merged.

Thanks. Will do. CLA is fine but it might take another week before I can sign

@jmoralez jmoralez merged commit cf2754c into Nixtla:main Nov 4, 2024
30 checks passed
@blackhole-canada
Copy link

Hello :) I am still getting an error. Is the fix implemented in the main branch or I have to pull from some another branch!

@andrewscottm
Copy link
Contributor Author

Yes, it's in the main branch. You could check you have the fix with, eg., print(inspect.getsource(statsforecast.arima.auto_arima_f))

@blackhole-canada
Copy link

Yes, it's in the main branch. You could check you have the fix with, eg., print(inspect.getsource(statsforecast.arima.auto_arima_f))

Sorry, I am new to it. How do I know if I have the fix from the output of print(inspect.getsource(statsforecast.arima.auto_arima_f))

@andrewscottm
Copy link
Contributor Author

The change is in that function. Please just check you have it. If not, then you likely haven't installed the updated base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants