-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: auto arima xreg rank deficient test #931
fix: auto arima xreg rank deficient test #931
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks! Can you please do this instead? X = np.hstack([np.ones([xregg.shape[0], 1]), xregg]) |
Done. yes, that's simpler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@andrewscottm can you please sign the CLA? Once that's done this should be automatically merged. |
Thanks. Will do. CLA is fine but it might take another week before I can sign |
Hello :) I am still getting an error. Is the fix implemented in the main branch or I have to pull from some another branch! |
Yes, it's in the main branch. You could check you have the fix with, eg., |
Sorry, I am new to it. How do I know if I have the fix from the output of |
The change is in that function. Please just check you have it. If not, then you likely haven't installed the updated base branch |
Corrects auto arima "xreg is rank deficient" test, as raised in #902