Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFT-Interpretability #1104

Merged
merged 8 commits into from
Aug 27, 2024
Merged

TFT-Interpretability #1104

merged 8 commits into from
Aug 27, 2024

Conversation

YA2424
Copy link
Contributor

@YA2424 YA2424 commented Aug 13, 2024

Added Interpretability for Temporal Fusion Transformer.

Changed the TFT class to return the needed parameters for interpretability and implemented methods for interpretability plots.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2024

CLA assistant check
All committers have signed the CLA.

@YA2424 YA2424 changed the title TFT-Interpretability Added TFT-Interpretability Aug 13, 2024
@YA2424 YA2424 changed the title Added TFT-Interpretability TFT-Interpretability Aug 13, 2024
@marcopeix
Copy link
Contributor

Thanks for the contribution! Here are a few comments to improve your PR and get it merged:

  • Merge the main branch into your working branch to update it
  • There a lot of changes made to documentation notebooks that shouldn't be modified. Please, revert those changes so they match what is on the main branch.
  • Ideally, we don't introduce new dependencies. Can you make it such that there's a method or attribute to extract the parameters, but then it's up to the user to download any plotting library to interpret them and plot them.

Let me know if you have any questions!

@YA2424
Copy link
Contributor Author

YA2424 commented Aug 22, 2024

Thanks for the contribution! Here are a few comments to improve your PR and get it merged:

  • Merge the main branch into your working branch to update it
  • There a lot of changes made to documentation notebooks that shouldn't be modified. Please, revert those changes so they match what is on the main branch.
  • Ideally, we don't introduce new dependencies. Can you make it such that there's a method or attribute to extract the parameters, but then it's up to the user to download any plotting library to interpret them and plot them.

Let me know if you have any questions!

Thanks for your response and comments.

All the changes you asked for are done.
Please, let me know if other changes are needed.

@marcopeix
Copy link
Contributor

@amirouyanis Thanks again for the PR, great work! Can you just add this header | eval: false to all the cells where you actually run the model? So all the cells after "Usage Example". That will make the tests pass. Thank you!

@marcopeix marcopeix self-requested a review August 27, 2024 14:48
@YA2424
Copy link
Contributor Author

YA2424 commented Aug 27, 2024

@amirouyanis Thanks again for the PR, great work! Can you just add this header | eval: false to all the cells where you actually run the model? So all the cells after "Usage Example". That will make the tests pass. Thank you!

@marcopeix Thank you :). The chages are Done!

@marcopeix marcopeix merged commit 8f48c59 into Nixtla:main Aug 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants