Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error when max_horizon and models_ don't match #204

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jmoralez
Copy link
Member

@jmoralez jmoralez commented Sep 11, 2023

Description

Raises errors in predict when the inner state has been modified by running fit + preprocess with different settings for max_horizon. Based on #201.

Checklist:

  • This PR has a meaningful title and a clear description.
  • The tests pass.
  • All linting tasks pass.
  • The notebooks are clean.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez marked this pull request as ready for review September 11, 2023 23:50
@jmoralez jmoralez merged commit f99f397 into main Sep 11, 2023
15 checks passed
@jmoralez jmoralez deleted the max-horizon-models-error branch September 11, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant