use nanmedian

Nixtla · Oct 12, 2023 · 80f6d50 · 80f6d50
1 parent 257399f
commit 80f6d50
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/build-python-package.yml b/.github/workflows/build-python-package.yml
@@ -2,7 +2,10 @@ name: Build python package
 
 on:
   push:
+    branches: [main]
     tags: ['v*']
+  pull_request:
+    branches: [main]
   workflow_dispatch:
 
 jobs:
@@ -33,11 +36,13 @@ jobs:
           CIBW_TEST_SKIP: '*-macosx_arm64'
 
       - uses: actions/upload-artifact@v3
+        if: github.event_name == 'push'
         with:
           path: ./wheelhouse/*.whl
 
   build_sdist:
     name: Build sdist
+    if: github.event_name == 'push'
     runs-on: ubuntu-latest
 
     steps:
@@ -56,8 +61,9 @@ jobs:
         with:
           path: ./dist/*.tar.gz
 
-  upload_all:
-    if: github.repository == 'Nixtla/coreforecast'
+  upload_artifacts:
+    name: 'Upload to PyPI'
+    if: github.repository == 'Nixtla/coreforecast' && startsWith(github.ref, 'refs/tags/v')
     needs: [build_wheels, build_sdist]
     runs-on: ubuntu-latest
     permissions:

diff --git a/tests/test_scalers.py b/tests/test_scalers.py
@@ -41,7 +41,7 @@ def robust_scaler_iqr_stats(x):
 
 def robust_scaler_mad_stats(x):
     median = np.nanmedian(x)
-    mad = np.median(np.abs(x - median))
+    mad = np.nanmedian(np.abs(x - median))
     return median, mad