Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-functions-core-tools: 3.0.3785 -> 4.0.4736 #181126

Closed
wants to merge 1 commit into from
Closed

azure-functions-core-tools: 3.0.3785 -> 4.0.4736 #181126

wants to merge 1 commit into from

Conversation

kfollesdal
Copy link
Contributor

Description of changes

Update azure-functions-core-tools: 3.0.3785 -> 4.0.4629

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kfollesdal
Copy link
Contributor Author

Result of nixpkgs-review pr 181126 run on x86_64-linux 1

1 package built:
  • azure-functions-core-tools

@kfollesdal kfollesdal added 8.has: package (update) This PR updates a package to a newer version needs_reviewer labels Jul 11, 2022
@ofborg ofborg bot requested a review from jshcmpbll July 11, 2022 15:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 11, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/582

winterqt
winterqt reviewed Aug 17, 2022
View reviewed changes
pkgs/development/tools/azure-functions-core-tools/default.nix Outdated
@@ -53,7 +53,7 @@ stdenv.mkDerivation rec {

installPhase = ''
mkdir -p $out/bin
cp -prd *.dll *.so gozip func $out/bin
cp -prd * gozip func $out/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this changed to be less granular for a reason? Furthermore, couldn't the explicit gozip and func arguments be removed since the wildcard matches everything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@winterqt yes the change to less granular was because when I was using command func it failed because it needed some of the files that was excluded. Good point that gozip and func can be removed, since wildcard. I will update the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity what was failing? Unfortunately I don't work with this tool much anymore so I haven't had much time to troubleshoot/validate updates to this package. Last I had worked on it there was an issue where it was referencing a hard coded path to bash that was causing some issues with I think push functions to azure but its been a while since I've used..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jshcmpbll, at the moment I do not remember exactly what was falling, made the PR in june. Should have written exactly what was failing, before I forgot. But I remember that copying over missing file solved the problem.

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 20, 2022
@kfollesdal kfollesdal changed the title azure-functions-core-tools: 3.0.3785 -> 4.0.4629 azure-functions-core-tools: 3.0.3785 -> 4.0.4736 Sep 2, 2022
@kfollesdal kfollesdal force-pushed the kfollesdal/azure-function-core-tools-4 branch from 4416879 to 1dd3d41 Compare September 2, 2022 16:18
@kfollesdal kfollesdal force-pushed the kfollesdal/azure-function-core-tools-4 branch from 1dd3d41 to 581f79a Compare September 2, 2022 16:19
jshcmpbll
jshcmpbll approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@jshcmpbll jshcmpbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than just getting additional context around some of the issue, LGTM :shipit:

@kfollesdal
Copy link
Contributor Author

Result of nixpkgs-review pr 181126 run on x86_64-linux 1

1 package built:
  • azure-functions-core-tools

@kfollesdal kfollesdal added needs_merger 12.approvals: 2 This PR was reviewed and approved by two reputable people backport release-22.05 and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-22.05 labels Sep 2, 2022
@GGG-KILLER
Copy link
Contributor

GGG-KILLER commented Nov 23, 2022 •
edited
Loading

As part of #202572, I was checking this and I saw that 4.0.4629 uses .NET 6.0, however this PR keeps it on .NET Core 3.1.

Is this correct @kfollesdal?

@GGG-KILLER GGG-KILLER mentioned this pull request Nov 23, 2022
Closed
7 tasks
@JamieMagee
Copy link
Member

This was superseded by #193902

@JamieMagee JamieMagee closed this Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winterqt winterqt winterqt left review comments

@jshcmpbll jshcmpbll jshcmpbll approved these changes

@billewanick billewanick billewanick approved these changes

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people needs_merger needs_reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kfollesdal @nixos-discourse @GGG-KILLER @JamieMagee @billewanick @jshcmpbll @winterqt @bobby285271