Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve oddities in Generic.Ideal documentation and implementation #1734

Open
fingolfin opened this issue Jun 19, 2024 · 1 comment
Open

Comments

@fingolfin
Copy link
Member

  • the source code says that it implements ideals over Euclidean domains
  • but the manual claims that also "univariate or multivariate polynomial ring over the integers" are supported
  • though maybe "over the integers" should be "over fields"? Then the next sentence would make more sense: "Univariate and multivariate polynomial rings over other domains (other than fields) are not supported at this time."
  • there is no Base.in method, arguably something rather central
  • there is no Base.isubset(I,J) method to test containment
  • there is a Base.contains(I,J) method which really should be a Base.issubset method
  • a bunch of the code seems to expect that all ideals are principle ideals - which is fine if one requires euclidean domains, but the docs claim (and some tests check) support for multiviariate polynomial rings...
@thofma
Copy link
Member

thofma commented Jun 19, 2024

Just for clarification. The implementation is for ideals in polynomials rings $R[x_1,\dotsc,x_n]$, where $R$ is a Euclidean domain, although there are some details in the implementation, which makes it only work $R = \mathbf{Z}$ or $R$ a field if I remember correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants