Skip to content
This repository has been archived by the owner on Apr 16, 2021. It is now read-only.

Review how we handle error codes #11

Open
mrcnski opened this issue Jul 17, 2020 · 4 comments
Open

Review how we handle error codes #11

mrcnski opened this issue Jul 17, 2020 · 4 comments

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Jul 17, 2020

We should know the StatusCodes we should receive and handle them accordingly. Something like a switch statement that handles different codes explicitly and gives a developer error if we have missed one?

Otherwise if that is over the top I think we should explicitly check for success and return an error if not so we aren't hiding any weird status codes that might create UX bugs or inconsistencies for users.

See #10 (review)

I'm thinking we treat >= 200 and < 300 as success and anything else as unexpected and therefore an error.

@ro-tex
Copy link

ro-tex commented Aug 3, 2020

We need to treat 3xx according to their specification - following redirects, etc. We can choose to return them to the caller, in case the API supports that or we decide that it should support it. But we can't treat a redirect as an error, especially now that siad is using redirects in order to ensure skylinks have a trailing /.

@mrcnski
Copy link
Contributor Author

mrcnski commented Aug 6, 2020

Seems like Go's http client will follow redirects automatically, so there's nothing we need to do there.

@ro-tex
Copy link

ro-tex commented Aug 17, 2020

In that case I'll close the issue.

@ro-tex ro-tex closed this as completed Aug 17, 2020
@ro-tex
Copy link

ro-tex commented Aug 17, 2020

I misread. We don't need to do anything special for the 3xx case but we still need to do that rest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants