You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
We should know the StatusCodes we should receive and handle them accordingly. Something like a switch statement that handles different codes explicitly and gives a developer error if we have missed one?
Otherwise if that is over the top I think we should explicitly check for success and return an error if not so we aren't hiding any weird status codes that might create UX bugs or inconsistencies for users.
We need to treat 3xx according to their specification - following redirects, etc. We can choose to return them to the caller, in case the API supports that or we decide that it should support it. But we can't treat a redirect as an error, especially now that siad is using redirects in order to ensure skylinks have a trailing /.
We should know the StatusCodes we should receive and handle them accordingly. Something like a switch statement that handles different codes explicitly and gives a developer error if we have missed one?
Otherwise if that is over the top I think we should explicitly check for success and return an error if not so we aren't hiding any weird status codes that might create UX bugs or inconsistencies for users.
See #10 (review)
I'm thinking we treat >= 200 and < 300 as success and anything else as unexpected and therefore an error.
The text was updated successfully, but these errors were encountered: