Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

dcgm-exporter gpu_collector_test.go's NewDCGMCollector broken #173

Open
shatil opened this issue Mar 30, 2021 · 0 comments
Open

dcgm-exporter gpu_collector_test.go's NewDCGMCollector broken #173

shatil opened this issue Mar 30, 2021 · 0 comments

Comments

@shatil
Copy link

shatil commented Mar 30, 2021

This unit test is broken on master and on tag 2.3.0. I had to delete the kubernetes_test.go file, which pulls in some exotic Kubernetes deps #172 to get the tests to run.

% go test ./...
go: finding module for package k8s.io/kubernetes/pkg/kubelet/apis/podresources/v1alpha1
go: finding module for package k8s.io/kubernetes/pkg/kubelet/util
go: found k8s.io/kubernetes/pkg/kubelet/util in k8s.io/kubernetes v1.20.5
go: k8s.io/[email protected] requires
	k8s.io/[email protected]: reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0

% rm kubernetes_test.go 

% go test ./...        
# dcgm-exporter [dcgm-exporter.test]
./gpu_collector_test.go:43:37: not enough arguments in call to NewDCGMCollector
	have ([]Counter)
	want ([]Counter, bool)
FAIL	dcgm-exporter [build failed]
FAIL
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant