-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proclaim_copyable_arguments for lambdas #2833
Merged
bernhardmgruber
merged 4 commits into
NVIDIA:main
from
bernhardmgruber:test_proclaim_lambda
Nov 28, 2024
Merged
Fix proclaim_copyable_arguments for lambdas #2833
bernhardmgruber
merged 4 commits into
NVIDIA:main
from
bernhardmgruber:test_proclaim_lambda
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
test_proclaim_lambda
branch
from
November 22, 2024 22:28
9c84e62
to
06dc946
Compare
I get a lot of these:
|
bernhardmgruber
force-pushed
the
test_proclaim_lambda
branch
2 times, most recently
from
November 26, 2024 09:44
60ea954
to
c8d9fa9
Compare
Suppressing the warning until NVBug 4980157 is fixed. |
bernhardmgruber
commented
Nov 26, 2024
Comment on lines
51
to
56
#if _CCCL_STD_VER < 2017 | ||
template <typename G> | ||
_LIBCUDACXX_HIDE_FROM_ABI constexpr __callable_permitting_copied_arguments(G&& g) | ||
: F(::cuda::std::forward<G>(g)) | ||
{} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below C++17, __callable_permitting_copied_arguments
is not an aggregate so it needs a ctor.
bernhardmgruber
changed the title
Test proclaim_copyable_arguments for lambdas
Fix proclaim_copyable_arguments for lambdas
Nov 26, 2024
miscco
approved these changes
Nov 26, 2024
bernhardmgruber
force-pushed
the
test_proclaim_lambda
branch
from
November 26, 2024 14:37
d1378fa
to
01ece91
Compare
Co-authored-by: Michael Schellenberger Costa <[email protected]>
bernhardmgruber
force-pushed
the
test_proclaim_lambda
branch
from
November 27, 2024 20:35
01ece91
to
e690a94
Compare
🟨 CI finished in 2h 18m: Pass: 99%/396 | Total: 8d 12h | Avg: 30m 55s | Max: 1h 20m | Hits: 51%/22090
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
+/- | Thrust |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 396)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
26 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 10h 31m: Pass: 100%/396 | Total: 8d 12h | Avg: 30m 54s | Max: 1h 20m | Hits: 51%/22090
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
+/- | Thrust |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 396)
# | Runner |
---|---|
327 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
26 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for proclaiming host/device extended lambdas as having copyable arguments. Needs to suppress a warning as well, which will be addressed by NVBug 4980157 eventually.
Fixes: #2834