Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flow import via clipboard is not working correctly for Linked Service #72

Closed
Shaquu opened this issue Mar 20, 2019 · 10 comments
Closed
Labels
bug 🐛 There is at least high chance that it is a bug! help wanted Used for setup help

Comments

@Shaquu
Copy link
Member

Shaquu commented Mar 20, 2019

Flow import via clipboard is not working correctly for Linked Service.
If flow contains Parent and Linked Service and Linked Service is assigned to Parent then when importing assignment will not recreate correctly - field will be unselected.

@Shaquu Shaquu changed the title Linked Service is not when pasteing flow Parent Service is not correctly assigned to Linked Service when pasting flow Mar 20, 2019
@Shaquu Shaquu added the bug 🐛 There is at least high chance that it is a bug! label Mar 20, 2019
@Shaquu Shaquu added the help wanted Used for setup help label Mar 30, 2019
@Shaquu Shaquu changed the title Parent Service is not correctly assigned to Linked Service when pasting flow [BUG] Flow import via clipboard is not working correctly for Linked Service Mar 30, 2019
@Shaquu
Copy link
Member Author

Shaquu commented Nov 29, 2019

From what I heard from node-red developers I cannot make import via clipboard in nrchkb similar to how it works in node-red native flows. So this issue can take a while.

@Shaquu
Copy link
Member Author

Shaquu commented Jan 28, 2020

TODO: Check if we can inform users better about that bug since it cannot be fixed due to design of node-red.

@Shaquu
Copy link
Member Author

Shaquu commented Jan 28, 2020

@NRCHKB/documentation please suggest how we can inform about this problem.
Then we will try to make such notification in node-red, add information in README and add warning in wiki pages (in pages where we use linked service).

@crxporter
Copy link
Member

I think the best option is to put comments in the wiki pages for examples of linked items. The current version won't deploy without an error if there's a "linked" item without a parent.

@crxporter
Copy link
Member

I need to check if some improvement has been done for this in nodered 1.2 release. I believe it deals some with duplicate config nodes, not sure if linked nodes are improved.

@Shaquu
Copy link
Member Author

Shaquu commented Oct 28, 2020

I can ask node-red big boss but I believe that it is another thing.

@crxporter
Copy link
Member

Could be fun to remind Mr Nick that we still want this... might have some momentum fresh off the 1.2 release?

@Shaquu
Copy link
Member Author

Shaquu commented Oct 29, 2020

Asked Nick but it seems he is on holiday. So it might take a while :)

@Shaquu
Copy link
Member Author

Shaquu commented Oct 29, 2020

UPDATE.
Possibly solved by latest node-red like you mentioned @crxporter

Nick mentioned this:
node-red/designs#37

@Shaquu Shaquu closed this as completed Oct 29, 2020
@Shaquu Shaquu reopened this Oct 29, 2020
@crxporter
Copy link
Member

Tested on Nodered 1.2.2 with NRCHKB 1.2.0.

Importing examples on a fresh pi works properly. Linked nodes come in linked.
Importing from one pi to another using clipboard works. Linked nodes come in linked.

This appears to be fixed if flows are properly exported and imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 There is at least high chance that it is a bug! help wanted Used for setup help
Projects
None yet
Development

No branches or pull requests

2 participants