Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add methods to export results in tabular format #280
base: dev
Are you sure you want to change the base?
add methods to export results in tabular format #280
Changes from 24 commits
6b8d3d3
cdd26c3
ec8b8ae
2207df1
c6e166a
32ca3dd
8e7945d
2592810
7f53de8
ad049c8
b220fb0
f98fa98
a8a8329
c6c33e6
a260338
3289683
d2272e2
cb49209
6a4da5f
edcc7db
05f9f76
bff7731
d4bf9fb
2c05efb
229a11d
32d78c3
b04226b
5fd4108
8137f7d
940eb19
e551dcc
f9ae9f2
1b00262
0d6bec3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the docstrings and comments based on my comments in
bgc.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for the new public methods
objects_to_tsv
andto_tsv
intest_nplinker_local.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part could be extracted to a
to_tabular
method with some modifications for both BGC and Spectrum classes.Then you could use pandas dataframe to faciliate the process of a list of objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this part into a
to_string
method. Let me know if that's okay as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's required to test public methods
to_tabluar
and optional to test private method_to_string
. So please add unit tests for the public methods.