rename globals.py to defaults.py #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CunliangGeng and the rest of your teammates on |
This was referenced Apr 17, 2024
Merged
|
Please ignore the failed tests which are caused by unstable GNPS website. |
gcroci2
approved these changes
Apr 18, 2024
Merge activity
|
`globals` is a name of python built-in function. So better to use `defaults` to avoid naming conflicts.
CunliangGeng
force-pushed
the
rename_globals_to_defaults
branch
from
2d31f45
to
a7b526a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalsis a name of python built-in function. So better to usedefaultsto avoid naming conflicts.