add aerosol related updates #161
Conversation
|
This is still in a draft mode. Please don't merge yet |
|
This should be ready now. |
|
ok should be good to go. More work is needed but this at least adds the capability for GEFS-Aerosols and RRFS to properly read the variables and assign unique variable names to each aerosol species. |
Co-authored-by: Zachary Moon <[email protected]>
Co-authored-by: Zachary Moon <[email protected]>
bbakernoaa
force-pushed
the
feature/better_aero
branch
from
5ad9c0d
to
e6c5096
Compare
|
How is this coming along? Do you think it is ready to merge? |
|
Yes I believe it is ready to go. This actually led us to find an error in the way they were assigning a grib variable in the RRFS prototype too. They were assigning the aerosol type as "Missing" for some of their species instead of total or 62000 |
|
Forgot to post these questions from my review a few days ago. Apologies. |
|
@EricEngle-NOAA Anything you want me to do to get this merged? |
|
@bbakernoaa can you create a test for this? See the tests/ dir at the repo root. We are using pytest. Also feel free to add a GEFS chem file to tests/data/, but thin the grid to 1.0 deg to keep a smaller file size. |
|
I think a test to make sure the shortName and fullName are properly constructed is good enough. That is all that this PR is for so no need to test data unpacking etc. |
|
Ok will do. I added the 2d data file here but may also add one for the 3d data |
This closes #160
Main updates were in the template.py and _grib2io.py files. More improvement could be completed later but it does produce a grib2 message now with unique shortNames and fullNames for each variable now.
Additionally the xarray backend works as well.