Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fre cmor config exposed #227

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Fre cmor config exposed #227

wants to merge 8 commits into from

Conversation

ilaflott
Copy link
Member

this PR takes hard-coded values/args/assumptions of fre/cmor/cmor_mixer.py and attempts to make it less dependent on such "hidden configuration".

…in new optional argument for additional control over file targeting. we also now have a \"run one file only\" style flag. new test config file fre/tests/test_files/CMORbite_var_list.json contains variables for processing test cases being workd through in run_test_file_cases.py with notes
…e code currently relies on. unsure how useful the exact way i wrote things down is, but im hoping ot leverage it for structure and or setting up some formulaic approaches and or rules. additionally, merge multiline printstateaments into one call using legal but maybe awkward looking multiline syntax, some other readability edits too
@ilaflott ilaflott added documentation Improvements or additions to documentation enhancement New feature or request priority: MEDIUM labels Oct 28, 2024
@ilaflott ilaflott self-assigned this Oct 28, 2024
@ilaflott ilaflott linked an issue Oct 30, 2024 that may be closed by this pull request
@ceblanton
Copy link
Collaborator

This looks like a quiet PR for a couple days. Is it ready for review?

@ilaflott
Copy link
Member Author

ilaflott commented Nov 5, 2024

draft PR status is "Hold" for now while we get other priorities/capabilities/issues straightened out.

@ilaflott ilaflott added clean up discussion Discuss an issue and it's solutions labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up discussion Discuss an issue and it's solutions documentation Improvements or additions to documentation enhancement New feature or request priority: MEDIUM
Projects
None yet
2 participants