-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fre cmor config exposed #227
Draft
ilaflott
wants to merge
8
commits into
main
Choose a base branch
from
fre-cmor-config-exposed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in new optional argument for additional control over file targeting. we also now have a \"run one file only\" style flag. new test config file fre/tests/test_files/CMORbite_var_list.json contains variables for processing test cases being workd through in run_test_file_cases.py with notes
…e code currently relies on. unsure how useful the exact way i wrote things down is, but im hoping ot leverage it for structure and or setting up some formulaic approaches and or rules. additionally, merge multiline printstateaments into one call using legal but maybe awkward looking multiline syntax, some other readability edits too
…see how it goes...
This was referenced Oct 28, 2024
ilaflott
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
priority: MEDIUM
labels
Oct 28, 2024
This looks like a quiet PR for a couple days. Is it ready for review? |
draft PR status is "Hold" for now while we get other priorities/capabilities/issues straightened out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clean up
discussion
Discuss an issue and it's solutions
documentation
Improvements or additions to documentation
enhancement
New feature or request
priority: MEDIUM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR takes hard-coded values/args/assumptions of
fre/cmor/cmor_mixer.py
and attempts to make it less dependent on such "hidden configuration".