remove deprecated reproduce_siena option
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and make_quick_mosaic
mlee03
approved these changes
Nov 20, 2024
|
@rem1776, could you make a quick issue that goes along with this PR? |
|
We actually had an issue for this already, but it was marked as closed: #232. No explanation as to why its closed tho, maybe it was still being used by someone? |
Double checked with Niki and he said it should be fine to remove. I guess why that original issue was closed will remain a mystery, but this PR should be good to go in. |
|
Thanks Ryan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just removes the old option