minor fix to set up GWD links when using RRFS_sas. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu5970
requested review from
MatthewPyle-NOAA,
ShunLiu-NOAA,
JacobCarley-NOAA and
BenjaminBlake-NOAA
as code owners
MatthewPyle-NOAA
approved these changes
Nov 19, 2024
BenjaminBlake-NOAA
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks @hu5970 . These changes should also be made to the main branch since dev-sci development should be mostly frozen at this point.
MatthewPyle-NOAA
changed the title
|
@BenjaminBlake-NOAA @MatthewPyle-NOAA I am checking real-time run (v0.9.1) and retro (v1.0.3) to see if there are any local changes need to be committed to dev-sci branch. Then I will commit all recent changes to main. Hopefully this is our latest round of change to the dev-sci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we need to add RRFS_sas option in two locations for setting GWD. I do not know if this is matter but does not hurt to set it with reasonable values.
This is compared with setups for winter retro v1.0.3 on Dogwood.