Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make_ics and make_lbcs to use umbrella data and COMOUT instead of nwges #539

Closed

Conversation

BenjaminBlake-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • In this PR, the nwges directory structure is removed from the make_ics and make_lbcs tasks. The make_ics task will now use the umbrella data structure ($DATAROOT/${RUN}_${PDY}${cyc}/${WGF}/ics) since initial condition data is only shared within the current cycle. @lgannoaa I shortened the name of the umbrella data directory from what you had to ${RUN}_${PDY}${cyc}, but this can be modified if needed. The make_lbcs task will now send the boundary condition files to COMOUT since those files are shared with other cycles.
  • An issue with the run directory name for the observer_gsi_ensmean tasks is fixed in FV3LAM_wflow.xml.
  • @lgannoaa I did not include your architecture design changes to the make_lbcs job here. I wanted to keep the scope of this PR smaller and I think those changes can be included in another PR.

TESTS CONDUCTED:

Completed successful tests with the fire weather nest and non-DA engineering workflow. @lgannoaa is planning to run more complete tests with these changes.

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@lgannoaa

@MatthewPyle-NOAA
Copy link
Contributor

@BenjaminBlake-NOAA I'm assuming this one will wait until after the real-time RRFS switches to using "main"?

@BenjaminBlake-NOAA
Copy link
Contributor Author

@MatthewPyle-NOAA Yes I think that would be best. @lgannoaa also wants to run some tests of his own so I'm going to leave this PR as a draft for now. There will be a few more changes needed to get the ecflow workflow working.

@BenjaminBlake-NOAA
Copy link
Contributor Author

After discussing with @lgannoaa, we feel that the ecflow configuration updates to the new task names and removing var_defns.sh should occur before updating the directory structure of the workflow. This PR will be closed and a new PR will be opened in the future.

@lgannoaa
Copy link
Contributor

Thank you @BenjaminBlake-NOAA for excellent team work. This system is large and complex by design. Although this PR is closed, we have a good foundation for the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants