Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer working with ip < 5.0? #734

Open
edwardhartnett opened this issue Jul 16, 2024 · 3 comments
Open

no longer working with ip < 5.0? #734

edwardhartnett opened this issue Jul 16, 2024 · 3 comments
Assignees
Labels
build Building software can be complicated

Comments

@edwardhartnett
Copy link
Contributor

Seems like we no longer build with the ip library less than version 5.0.

Is there any way we could notice in the cmake what version of ip we have, and still handle versions before 5.0?

@edwardhartnett
Copy link
Contributor Author

@AlexanderRichert-NOAA would we just have to #ifdef the "use" commands to make this work?

@edwardhartnett
Copy link
Contributor Author

OK, we will just live with this. ip-5.0.0 is already on WCOSS2 so it's not a difficult requirement.

@AlexanderRichert-NOAA
Copy link
Contributor

Sorry I missed your previous comment-- Yes, for other developers I've been advising them to use #ifdef to accommodate older versions. For example, for sp_mod, UPP's ncep_post CMake config uses:

    if(ip_VERSION VERSION_GREATER_EQUAL 5.1)
      target_compile_definitions(${EXENAME} PRIVATE USE_SP_MOD=1)
    endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Building software can be complicated
Projects
Status: To do
Development

No branches or pull requests

2 participants