Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison to single emission screen #68

Open
PierreBresson opened this issue Feb 3, 2020 · 5 comments
Open

Add comparison to single emission screen #68

PierreBresson opened this issue Feb 3, 2020 · 5 comments
Labels
🆕 Feature New feature - approved by the team

Comments

@PierreBresson
Copy link
Member

PierreBresson commented Feb 3, 2020

Add comparison to single emission screen

Use shift project data for calculation of the charge smartphones.

In EmissionItemScreen.tsx add a component like this <Comparison emission={emission} /> before the Button.Primary

If it's a emission by car, do not display the comparison with car.

Add a line after the comparison with charge smartphone (not visible on the picture) saying :

if(emissionModelType === shortHaulFlight || emissionModelType === mediumHaulFlight || emissionModelType === longHaulFlight ) {
You could have decrease your carbon footprint by XX % if you had use a train
}

if(emissionModelType === car ) {
You could have decrease your carbon footprint by XX % than if you took a train
}

if(emissionModelType === bus ) {
Good job, you saved XX kgCO2 eq by not driving a car
}

if(emissionModelType === train ) {
if(value < 400){
Good job, you saved XX kgCO2 eq by not driving a car
} else {
Good job, you saved XX kgCO2 eq by not flying a plane
}
}

This is a big task. Use ramda whenever it's possible, and add tests to this Comparison "local" component (local meaning that I don't think it needs to live in app/components because I don't see where I could be used anywhere else).

Item

@PierreBresson PierreBresson added the 🆕 Feature New feature - approved by the team label Feb 3, 2020
@PierreBresson PierreBresson added hacktoberfest https://hacktoberfest.digitalocean.com/ 🍦 Nice to have Cool, but not urgent labels Oct 3, 2020
@schezfaz schezfaz removed their assignment Oct 4, 2020
@PierreBresson PierreBresson added hacktoberfest https://hacktoberfest.digitalocean.com/ and removed hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 5, 2020
@PierreBresson PierreBresson removed the 🍦 Nice to have Cool, but not urgent label Oct 23, 2020
@PierreBresson
Copy link
Member Author

Screenshot 2020-10-09 at 10 56 57

Display the tree calculation like on the picture. The number of trees should be in blue / bold.
More info : https://www.websitecarbon.com/ and find code on https://gitlab.com/wholegrain/carbon-api-2-0

@PierreBresson PierreBresson removed the hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 1, 2020
@PierreBresson PierreBresson added the 🚧 Pending Planned but not ready to be enterely coded yet label Apr 29, 2021
@Michelalmeidasilva
Copy link

Hello my friend!

can i take this issue to do?

@Michelalmeidasilva
Copy link

should the content be displayed in the app the same way as the image, or should it just have the same information?

@PierreBresson
Copy link
Member Author

@Michelalmeidasilv thanks for taking a look. I've updated the design and made it easier, let's do the full comparison later. Let me know if you need guidance and not sure about the edge cases.

Single Emission v2

@PierreBresson PierreBresson added hacktoberfest https://hacktoberfest.digitalocean.com/ and removed 🚧 Pending Planned but not ready to be enterely coded yet labels Sep 23, 2021
@Michelalmeidasilva
Copy link

@Michelalmeidasilv thanks for taking a look. I've updated the design and made it easier, let's do the full comparison later. Let me know if you need guidance and not sure about the edge cases.

Single Emission v2

Sorry for taking so long to answer, at the end of this week I will finish this task

Thanks a lot to updated this design!

About this task, I'll go deeper into it during the week and talk to you if I have any questions.

@PierreBresson PierreBresson removed the hacktoberfest https://hacktoberfest.digitalocean.com/ label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 Feature New feature - approved by the team
Projects
None yet
Development

No branches or pull requests

3 participants