Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group_by issues #187

Open
pinarda opened this issue Oct 10, 2020 · 3 comments
Open

Fix group_by issues #187

pinarda opened this issue Oct 10, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pinarda
Copy link
Collaborator

pinarda commented Oct 10, 2020

we want to group_by before we calculate metrics, not after. We could possible add an option to do either, but see odds_positive and standardized_mean where the values are very different depending on which order they are calculated in.

@pinarda pinarda added the bug Something isn't working label Oct 10, 2020
@pinarda pinarda added this to the Release 2 milestone Oct 10, 2020
@allibco allibco self-assigned this Feb 22, 2021
@allibco
Copy link
Collaborator

allibco commented Mar 18, 2021

@pinarda it looks like right now we do the group_by before the metric for odds_positive and standardized_mean (why not odds_negative?),

and everything else does the metric first then the group by. Is this request saying that you always want the group by to happen first?

Also this only affects timeseries plots right?

@allibco
Copy link
Collaborator

allibco commented Mar 18, 2021

ignore the odds_negative comment - doesn't exist :)

@pinarda
Copy link
Collaborator Author

pinarda commented Mar 29, 2021

See odds_positive and standardized_mean metrics, we group_by first because we need an intermediate metric that must be calculated per group (mean, std etc.). Otherwise on line 196 of plot.py we end up grouping after the metric is computed. This may return the same value as grouping before we calculate the metric for most metrics (check that this is true).

@pinarda pinarda self-assigned this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants