Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor H2 star formation parameters #177

Open
bwkeller opened this issue Jul 18, 2024 · 1 comment
Open

Refactor H2 star formation parameters #177

bwkeller opened this issue Jul 18, 2024 · 1 comment
Assignees
Labels

Comments

@bwkeller
Copy link
Contributor

When COOLING_MOLECULARH is enabled, an additional parameter is added, dStarFormEfficiencyH2. This parameter behaves both like a boolean to enable or disable H2-based efficiencies (1 or 0 respectively) but also acts as a multiplicative factor on dCStar as well. If a user presumes that this is the H2 version of dCStar, they will end up with an efficiency parameter that is 5% what they expect, as it will be multiplied by the default value of dCStar (0.05). We should change this to a boolean parameter, bStarFormEfficiencyH2, and remove it from the calculation of the efficiency (just use it as a switch).

@trquinn
Copy link
Member

trquinn commented Jul 18, 2024

@CharlotteRuth this was originally implemented in GASOLINE with the following comment:

double dStarFormEfficiencyH2; /* Star formation efficiency, CStar, is multiplied by dStarFormEfficiencyH2 times the fraction of hydrogen in molecular form  */

Was there a reason to have this parameter be degenerate with CStar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants