Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectButton error: '_delete' has already been declared #20294

Open
VictorBlockchain opened this issue Nov 16, 2024 · 1 comment
Open

ConnectButton error: '_delete' has already been declared #20294

VictorBlockchain opened this issue Nov 16, 2024 · 1 comment
Assignees
Labels
dapps dapps

Comments

@VictorBlockchain
Copy link

VictorBlockchain commented Nov 16, 2024

import { ConnectButton } from '@mysten/dapp-kit';
ConnectButton error

Steps to Reproduce Issue

install '@mysten/dapp-kit', @Vanilla-Extract is a dependency and you'll get this error
worked fine with wallet-kit...

./node_modules/@vanilla-extract/css/node_modules/lru-cache/dist/esm/index.js
Module parse failed: Identifier '_delete' has already been declared (1402:9)
| }
| }

function _delete(k, reason) {
| var _class_private_field_get1;
| var _this, _this1, _ref, _this2, _this3, _ref1;

@VictorBlockchain VictorBlockchain changed the title '_delete' has already been declared ConnectButton error: '_delete' has already been declared Nov 16, 2024
@stefan-mysten stefan-mysten added the dapps dapps label Nov 17, 2024
@williamrobertson13
Copy link
Contributor

williamrobertson13 commented Nov 18, 2024

Hi @VictorBlockchain! Do you have a minimal reproduction you could share? I do see some issues with our build pipeline that result in vanilla-extract dependencies being included when they shouldn't, so let me take a stab at fixing that and I'll report back.

williamrobertson13 added a commit that referenced this issue Nov 18, 2024
## Description 
Potentially addresses #20294.
The vanilla-extract libraries are internal dependencies as we ship the
library with raw CSS files.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapps dapps
Projects
None yet
Development

No branches or pull requests

4 participants