Fix much Torquestuff #1542
Open
Fix much Torquestuff #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert Vector6 to a struct - convert availableTorque to a Vector6 - convert Vector6 ToVector3d in a few places to maintain backcompat (places that may continue to be buggy I suspect, but out of scope for now) - in the BetterController select which torque 'sense' to use based on the sign of the component of the error vector (asymmetric torque handling) - Abs() the values coming off of GetPotentialTorque() and fix the sense of the vector manually to work around KSP bugginess with pos/neg values being all over the place. Signed-off-by: Lamont Granquist <[email protected]>
Signed-off-by: Lamont Granquist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(places that may continue to be buggy I suspect, but out of scope for now)
the sign of the component of the error vector (asymmetric torque
handling)
of the vector manually to work around KSP bugginess with pos/neg
values being all over the place.