Loop function / Active Class #15
Conversation
|
Apologies for not getting back to you sooner. I'll have a look this week. |
| @@ -22,6 +22,8 @@ | |||
| animation: "bounceIn", | |||
| separator: ",", | |||
| speed: 2000, | |||
| activeClass: 'active', | |||
There was a problem hiding this comment.
Can we use double quotes here for consistency? I think with the new ESLint configuration, this should be caught.
| @@ -22,6 +22,8 @@ | |||
| animation: "bounceIn", | |||
| separator: ",", | |||
| speed: 2000, | |||
| activeClass: 'active', | |||
| loop: 10, // loop n times around TBC | |||
There was a problem hiding this comment.
I'm not sure if I'm keen on including an out-of-the-box support for a loop limit. Seems like something that can be achieved by the complete callback.
|
|
||
|
|
||
|
|
||
| //console.log(this.position); |
There was a problem hiding this comment.
Possibly want to remove the comment here.
| this.index = ++this.index % this.phrases.length; | ||
| this.element[0].innerHTML = "<span class=\"animated " + this.settings.animation + "\">" + this.phrases[this.index] + "</span>"; | ||
| this.element[0].classList.add(this.settings.activeClass); |
There was a problem hiding this comment.
I'm not sure if it's necessary for us to add in every iteration. I feel like there should be a more elegant solution (e.g. setting a base class on the parent element, and having its style get overwritten by morphext on line 41/45).
More ideas forth coming.