Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive Improvements for Global Illumination and Sky Shader #638

Open
6 tasks done
leonardofries opened this issue Oct 3, 2024 · 9 comments
Open
6 tasks done

Massive Improvements for Global Illumination and Sky Shader #638

leonardofries opened this issue Oct 3, 2024 · 9 comments
Labels
asset-submission Contributing blend files to include as resources in MCprep itself
Milestone

Comments

@leonardofries
Copy link

leonardofries commented Oct 3, 2024

Name of asset submission

[Improvement] Massive Improvements for Global Illumination and Sky Shader

Quality checks

  • I have read, understood, and applied all the conventions of this page
  • This file was last saved in blender 2.80 (for backwards compatibility)
  • This is a vanilla minecraft asset/mob/effect, and uses only vanilla textures
  • I am the sole creator of this rig, other than any textures by Mojang. Any custom textures I created myself.
  • That I, submitter of this rig, will be active in all discussion on this submission, and understand that not responding to comments on this submission could result in this submission being rejected.

Describe any usage details

I've redone the World Shader so the Sky and Global Illumination look more like the trailers from Mojang. This is perfect for use with the Barebones Texture Pack.

Parts of the changes are:

  • Separated GI from Sky, so you can change the "Skybox" without changing the GI (hence the more trailer feeling).
  • Modified current gradients to feel more like the trailers.
  • Created a better Star System and Fixed the time-passing issue, it now works on time-lapses.
  • Created a Procedural Day/Night Cycle with an interchanging Sun and Moon.
  • Added a Volume Absorption to Help with the Trailer Feeling (Turn off Light Tree in newer blender versions).
  • Added a Cloud Movement according to Time.
  • Created a new Water Shader that should resemble the Trailers a little.

I tried my best to make the shader readable. Changes are located on:
Shader Tab > World
Volume > Shader Tab
Sun/Moon > Transform Rotation & Custom Property for Extra Rotation Control & Shaders
Render Tab > Color Management

I'll make a youtube tutorial explaining in depth the changes and how to recreate the Trailer Style on my YouTube in the future too. For now, you can dissect the changes I made on the file
Not sure on how to send the file so here's the Drive link for it.
https://drive.google.com/file/d/1CsUnoDbMkXsSGKEB9-5KwWnyXCa1Lvqx/view?usp=drive_link

Day1

Night1

Home1

[IMPORTANT UPDATE]

Tutorial Incoming - Should last 20 minutes and explain how I made the shader from the ground up

Shader Fix - I like to iterate my creations, and this one I have fixed it to an even better point.
Fully works in Eevee, Cycles, Blender 4.2, and up to 2.8. More Minecraft feel. Works with default texture pack.
Patch coming this week (06/10)

What name should we use to credit you in the README.md file?

Leonardo Frito

What credit url should we use to reference you in the README.md file?

instagram.com/leonardofrito

Confirmation

  • By submitting this asset, I affirm the asset is of my own creation. I understand this asset will be included with MCprep with a CC-BY (attribution) license agreement, and that users of MCprep should refer to MCprep's readme for credit or directly name me for credit when this rig is used.
@leonardofries leonardofries added the asset-submission Contributing blend files to include as resources in MCprep itself label Oct 3, 2024
@leonardofries leonardofries changed the title [Improvement] Massive Improvements for Global Illumination and Sky Shader Massive Improvements for Global Illumination and Sky Shader Oct 3, 2024
@TheDuckCow
Copy link
Member

Looks really nice @leonardofries!

I'm curious, do you think at this moment that this shader setup would be appropriate for all users - Ie replacing the current one entirely, or that it should be an additional option?

The other detail is that we want to support as old versions of blender as possible - when I get a chance I'll see how far I can downgrade or, but are you aware of which version of blender you saved it on/any features it's using which would prevent it from being used in the 2.8x or 3.x series? Not necessarily a blocker, but is a consideration.

Looking forward to the tutorial - and appreciate your patience while we review.

@StandingPadAnimations
Copy link
Collaborator

I'm curious, do you think at this moment that this shader setup would be appropriate for all users - Ie replacing the current one entirely, or that it should be an additional option?

I think we could add this as a separate "trailer" option, since this is more geared for a trailer style, but then backport parts of it the current "in-game" sky

@leonardofries
Copy link
Author

@TheDuckCow It can be used by all players without problems. I made the whole day and night cycle for that. I have given a lot of creative control over the entire thing, so you can turn the Global Illumination on and off or change the strength of it. As far as I'm concerned the default values I left at will make the render look like the trailers when used with the Barebones texture pack, but should look good on the default textures too.

And about Backwards compatibility, that's something to be checked, I don't think it would go all the way to 2.8, but it can go back a couple versions with no issues

@TheDuckCow
Copy link
Member

Ok that's a good suggestion @StandingPadAnimations, giving it as another option would also mitigate the need to get it working too far back in terms of blender versions. I'm not sure how common it would be, but perhaps we could actually generalize the system such that we have a skies folder for different sky setups, allowing users to create their own custom ones. A little extra work, but would make it more feasible to merge this work in sooner.

Uploading your source blend after zipping it up, so we have a longer term record of it (in case the drive link dies)
Proj Terr - Barebones.blend.zip

Demo file is really nice @leonardofries! Curious, have you rendered this out and shared somewhere? Would love a to link to it.

@leonardofries
Copy link
Author

@TheDuckCow I'll have a video by tomorrow. For now I only have these weird test images and the ones on the original post
1 - Blossom - Lyncon 2
1 - Blossom - Lyncon
2 - Bau - Lyncon

@TheDuckCow
Copy link
Member

lol wonderful, looking forward to it haha

@leonardofries
Copy link
Author

Good news and not so bad news.
It seems to be fully compatible up to 2.8. But one thing will be missing. I wasn't around the 2.8 era, I think I came in at 2.83 and only learned it fully at 2.9. So, not sure on this one, but you can't add a Input to Rotation on the Mapping Node, so I could not think of a way of making the stars rotate in the background as the time passes. The rest works fine. I'll be uploading these files soon

_Teste.-.Cena.Bau.LQ.mp4

@leonardofries
Copy link
Author

Default Texture Pack Checks Out for me!
Default Test - 4
Default Test - 1
Default Test - 2
Default Test - 3

@leonardofries
Copy link
Author

image
Works exactly the same as in blender 4.4 except for Rotating Stars As The Time Pass and the Truncate Modulo that fixes the time thing. I don't have time to fix these, but the Truncate Modulo can be made with the Math Nodes Available. And I'm pretty sure theres a way to animate the rotation of the noise texture (ie: stars)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset-submission Contributing blend files to include as resources in MCprep itself
Projects
Status: In Review
Development

No branches or pull requests

3 participants