Fix memo in withdrawal example #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withdrawal-memo in buildSafeTransaction is not the actual memo. It only exists in Mixin mainnet. e.g. For a EOS transaction. If you specify the memo in the field of 'withdrawal-memo' (which is an argument of buildSafeTransaction), you won't receive your fund on the other side. It turns out you can only set the memo in 'recipients' to initiate a successful withdrawal. Failed example (No Memo): https://mixin.space/tx/c4c145e3d8c562b13002cc080cfdd5b89a6978a877fcc678ddbd3f7d978965f5 https://eosflare.io/tx/FE73D7CCC4319C4EA931657CA402C57886F4AF87203AAA9B7E8FE183ECD8EEF2 Success example (With Memo): https://mixin.space/tx/4430151efdb35cc26b6863e7048417beb3ad88e3b45149efdb55d73f576bdd26 https://eosflare.io/tx/8CDB5B8DBB97718FDB5B71570B9316AACCB1E0D59BD2841EDCE8EC66057A90A3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withdrawal-memo in buildSafeTransaction is not the actual withdrawal memo. It only exists in Mixin mainnet.
e.g. For a EOS transaction. If you specify the memo in the field of 'withdrawal-memo' (which is an argument of buildSafeTransaction), you won't receive your fund on the other side. It turns out you can only set the memo in 'recipients' to initiate a successful withdrawal.
Failed example (No Memo):
https://mixin.space/tx/0750c5c1ca296f0bcc5def010cc075bc3a0b854572ff69c8bc6070fe65748a5f
https://eosflare.io/tx/FE73D7CCC4319C4EA931657CA402C57886F4AF87203AAA9B7E8FE183ECD8EEF2
Success example (With Memo):
https://mixin.space/tx/4430151efdb35cc26b6863e7048417beb3ad88e3b45149efdb55d73f576bdd26
https://eosflare.io/tx/8CDB5B8DBB97718FDB5B71570B9316AACCB1E0D59BD2841EDCE8EC66057A90A3