Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render method couples view to controller #448

Open
tyrsson opened this issue Jun 30, 2024 · 1 comment
Open

Render method couples view to controller #448

tyrsson opened this issue Jun 30, 2024 · 1 comment

Comments

@tyrsson
Copy link

tyrsson commented Jun 30, 2024

I would have opened a discussion but you do not have them enabled :P

Just curious as to why you chose to couple the rendering to the controller layer?

@MissAllSunday
Copy link
Owner

MissAllSunday commented Aug 28, 2024

Sorry I didn't saw this before.

The main reason is mostly to save time, this mod is still highly couple to what SMF offers. Indeed "render" is not an appropriate name for what that function does.

Didn't know we can have discussions enable, will look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants