Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#428] 내 정보 get api 통합 + 링크미리보기 설정 #438

Merged
merged 15 commits into from
Oct 8, 2024

Conversation

moondda
Copy link
Contributor

@moondda moondda commented Oct 1, 2024

✨ 해당 이슈 번호 ✨

closed #428

todo

  • 필명 get + 소개글 get api 두개를 하나로 통합한 거 반영
  • 링크 미리보기 설정
  • 댓글 unique key 설정

📌 내가 알게 된 부분

📌 질문할 부분

  • 로컬 환경에서는 미리보기 이미지를 확인할 수 없으므로, 배포 후 테스트해보고, 제대로 반영이 안되어있으면 핫픽스로 수정할게요!
  • 쿼리키 부분에서 todaytopic은 topic의 0번째로 들어가고, curious는 groupinfo get에 통합되어서 그 부분 제거하였습니다!

📌스크린샷(선택)

@moondda moondda added ✨ Feature 새로운 기능 추가 (새로운 구현) 다현 labels Oct 1, 2024
@moondda moondda self-assigned this Oct 1, 2024
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mile-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 2:40pm

Copy link
Member

@ljh0608 ljh0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니다 빠른 반영 감사합니다!

if (checkAuthenticate()) {
const response = await authClient.get<WriterNamePropTypes>(`/api/moim/${groupId}/writername`);
console.log(response.data, 'fetch');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3) console 지워주세요!

Copy link
Contributor

@se0jinYoon se0jinYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moondda moondda merged commit b04bb98 into develop Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 추가 (새로운 구현) size/m size/m 다현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] 글모임 통합 정보 GET + 짜잘한 qa
3 participants