Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiSTer_example.ini installed on fresh install instead of MiSTer.ini #865

Open
drag0nneus opened this issue Jan 11, 2024 · 4 comments
Open

Comments

@drag0nneus
Copy link

For some reason when I had upgraded Mister using the update_all script, I couldnt get HDMI out to work on a screen larger than 20"
I ran a fresh install on a new SD card and noticed that the MiSTer.ini file was missing and in its place again was MiSTer_example.ini

Downloaded this MiSTer.ini from here now screen is fine

@birdybro
Copy link
Member

birdybro commented Jan 11, 2024

MiSTer.ini is missing from the https://github.com/MiSTer-devel/Distribution_MiSTer repository on purpose so that the file doesn't get replaced. Compatible defaults get loaded if there is no MiSTer.ini file. The file not being present on the sdcard on a fresh install is intended.

@limi
Copy link
Contributor

limi commented Nov 26, 2024

This should be reconsidered — that behavior is undiscoverable and user-hostile. I know it sucks to update the standard INI every time a default changes, but must be ways to make that less painful instead.

Omitting the file when all info online says “go edit MiSTer.ini” has hit many of our users, “the file is not there!?”.

@birdybro
Copy link
Member

The ini_settings script pulls down an updated MiSTer.ini automatically if it's missing anyways. A fresh install merely needs the user to run the ini_settings script once while on the network.

https://github.com/MiSTer-devel/Scripts_MiSTer/blob/master/ini_settings.sh#L823

That being said, maybe if some kind of versioning tag were added to the MiSTer.ini then the ini_settings script and the downloader could update it while keeping the settings the same.

@sorgelig
Copy link
Member

ini file in general should not be used. This is especially made for non-experienced user.
If user is experienced enough then he/she can rename example file and use. If it's too difficult, then user is considered non-experienced, so ini file should not be used in that case.
Pretty much logical.

Version control is required only if there are incompatible changes happens. I avoid any incompatibilities between versions, so no version control required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants