Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tight dependency on ThreeJS repo for draco loader #459

Open
afonsobspinto opened this issue Dec 20, 2022 · 3 comments · Fixed by #461
Open

Remove tight dependency on ThreeJS repo for draco loader #459

afonsobspinto opened this issue Dec 20, 2022 · 3 comments · Fixed by #461
Assignees
Labels
enhancement New feature or request

Comments

@afonsobspinto
Copy link
Member

As a continuation of #430 we should rethink the way we are setting the dracoLoader path to avoid future problems with threejs changes.

@afonsobspinto afonsobspinto added the enhancement New feature or request label Dec 20, 2022
@afonsobspinto afonsobspinto added this to the Patch milestone Dec 20, 2022
@afonsobspinto afonsobspinto changed the title Remove tight dependency on ThreeJS repo Remove tight dependency on ThreeJS repo for draco loader Dec 20, 2022
@afonsobspinto afonsobspinto removed this from the Patch milestone Dec 20, 2022
@enicolasgomez
Copy link
Contributor

Apparently we can use the node_modules/ThreeJS draco encoders that are already in the repo.

@afonsobspinto
Copy link
Member Author

Try with webpack copy plugin

@afonsobspinto
Copy link
Member Author

Relying on webpack doesn't seem the best option to me because that's a fix at the application level.

Setting the draco loader path to the folder in node modules seems to work:

    dracoLoader.setDecoderPath('../../../node_modules/three/examples/js/libs/draco/');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants