-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tight dependency on ThreeJS repo for draco loader #459
Labels
enhancement
New feature or request
Comments
afonsobspinto
changed the title
Remove tight dependency on ThreeJS repo
Remove tight dependency on ThreeJS repo for draco loader
Dec 20, 2022
Apparently we can use the node_modules/ThreeJS draco encoders that are already in the repo. |
Try with webpack copy plugin |
Relying on webpack doesn't seem the best option to me because that's a fix at the application level. Setting the draco loader path to the folder in node modules seems to work:
|
afonsobspinto
added a commit
that referenced
this issue
Dec 20, 2022
afonsobspinto
added a commit
that referenced
this issue
Dec 21, 2022
afonsobspinto
added a commit
that referenced
this issue
Dec 26, 2022
afonsobspinto
added a commit
that referenced
this issue
Dec 26, 2022
afonsobspinto
added a commit
that referenced
this issue
Dec 26, 2022
afonsobspinto
added a commit
that referenced
this issue
Dec 26, 2022
enicolasgomez
added a commit
that referenced
this issue
Jan 10, 2023
#459 fix: Update default draco decoder path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a continuation of #430 we should rethink the way we are setting the dracoLoader path to avoid future problems with threejs changes.
The text was updated successfully, but these errors were encountered: