Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid: Comparer implementation for custom sorting #5843

Merged
merged 9 commits into from
Nov 14, 2024

Conversation

tesar-tech
Copy link
Collaborator

Description

Closes #5839

Implements comparer. Usage in example page.

TODOs :

  • Add comparer to datagrid api page
  • update release notes

@stsrki
Copy link
Collaborator

stsrki commented Nov 14, 2024

This should work. But we need to mention in the docs that it only makes sense for in-memory data. If the user fetch only partial data from the API then this can only sort on that amount of data.

@stsrki
Copy link
Collaborator

stsrki commented Nov 14, 2024

TODOs :

  • Add comparer to datagrid api page
  • update release notes

Please finish this so I we can merge it.

@stsrki stsrki merged commit fbec551 into master Nov 14, 2024
2 checks passed
@stsrki stsrki deleted the dev/detagrid-custom-sorting branch November 14, 2024 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Sorting for custom compare method
2 participants